Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -deprecation JVM flag #9718

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Remove -deprecation JVM flag #9718

merged 1 commit into from
Nov 11, 2024

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Nov 8, 2024

Description:

Remove -deprecation JVM flag after fixing upstream library

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <[email protected]>
@steven-sheehy steven-sheehy added this to the 0.118.0 milestone Nov 8, 2024
@steven-sheehy steven-sheehy self-assigned this Nov 8, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner November 8, 2024 22:00
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (48a6b44) to head (41d8345).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9718      +/-   ##
============================================
- Coverage     92.23%   92.23%   -0.01%     
  Complexity     7628     7628              
============================================
  Files           937      937              
  Lines         32121    32121              
  Branches       4070     4070              
============================================
- Hits          29627    29626       -1     
  Misses         1542     1542              
- Partials        952      953       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 8, 2024

@steven-sheehy steven-sheehy changed the title Remote -deprecation JVM flag Remove -deprecation JVM flag Nov 10, 2024
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 8e18691 into main Nov 11, 2024
33 checks passed
@steven-sheehy steven-sheehy deleted the remove-deprecation-flag branch November 11, 2024 15:28
bilyana-gospodinova pushed a commit that referenced this pull request Nov 18, 2024
Remove -deprecation JVM flag after fixing upstream library

Signed-off-by: Steven Sheehy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants