-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to the bootstrap flow #9717
Conversation
Signed-off-by: Nir Ben-Or <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9717 +/- ##
============================================
- Coverage 92.23% 92.23% -0.01%
Complexity 7628 7628
============================================
Files 937 937
Lines 32121 32121
Branches 4070 4070
============================================
- Hits 29627 29626 -1
Misses 1542 1542
- Partials 952 953 +1 ☔ View full report in Codecov by Sentry. |
hedera-mirror-importer/src/main/resources/db/scripts/bootstrap.env
Outdated
Show resolved
Hide resolved
Signed-off-by: Nir Ben-Or <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
CREATE_MIRROR_API_USER
env var tobootstrap.env
, defaults totrue
CREATE_MIRROR_API_USER
as an OR condition toinit.sh
for the creation of themirror_api
user if $SCHEMA_V2 or $CREATE_MIRROR_API_USER are true.INIT_SH_URL
inbootstrap.sh
to download the init script frommain
branch rather than the respective version tags where it still contains the old version of init.sh.MIRRORNODE_VERSION
variable frombootstrap.sh
as it is no longer being used anywhere in the script following the change toINIT_SH_URL
.bootstrap.md
docs: add an entry at the end of the process to start the mirrornode importer.Related issue(s):
Notes for reviewer:
I've used this process to test the changes:
true
for themirror_api
user to be created.flyway_schema_history
table to verify there's no entry "0"; The results begin with "1.0" from 2019-09-09.Checklist