Fix restjava topics info endpoint ingress path regex #9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <[email protected]>
xin-hedera
added
bug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9670 +/- ##
============================================
+ Coverage 92.21% 92.36% +0.14%
+ Complexity 7609 7505 -104
============================================
Files 932 910 -22
Lines 31940 31538 -402
Branches 4029 3987 -42
============================================
- Hits 29455 29131 -324
+ Misses 1535 1465 -70
+ Partials 950 942 -8 ☔ View full report in Codecov by Sentry. |
steven-sheehy
approved these changes
Oct 28, 2024
xin-hedera
deleted the
9669-issue-to-retrieve-hcs-messages-from-topics-using-the-sequence-number
branch
xin-hedera
added a commit
that referenced
this pull request
Oct 28, 2024
- Add $ at the end Signed-off-by: Xin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the ingress path regex for restjava topics info endpoint
$at the endRelated issue(s):
Fixes #9669
Notes for reviewer:
Ideally, we should use
^/api/v1/topics/(\d+\.){0,2}\d+$, so traefik matches usingPathRegexp(``^/api/v1/topics/(\d+\.){0,2}\d+$``). However, k8s ingress spec mandatespathbegins with/.The change has been manually applied to previewnet:
https://previewnet.mirrornode.hedera.com/api/v1/topics/0.0.3886/messages
https://previewnet.mirrornode.hedera.com/api/v1/topics/0.0.3886/messages/100
Checklist