Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties in historical data ingestion documentation #9632

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Neurone
Copy link
Contributor

@Neurone Neurone commented Oct 24, 2024

Description:

Fixing parameter position

Related issue(s):

N/A

Notes for reviewer:

N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Giuseppe Bertone <[email protected]>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (d1b41f1) to head (86c1c07).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9632      +/-   ##
============================================
+ Coverage     92.22%   92.31%   +0.09%     
+ Complexity     7609     7505     -104     
============================================
  Files           932      914      -18     
  Lines         31940    31684     -256     
  Branches       4029     4007      -22     
============================================
- Hits          29456    29250     -206     
+ Misses         1535     1489      -46     
+ Partials        949      945       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-sheehy steven-sheehy added this to the 0.117.0 milestone Oct 24, 2024
@steven-sheehy steven-sheehy added the documentation Type: Improvements or additions to documentation label Oct 24, 2024
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 1687a55 into hashgraph:main Oct 24, 2024
32 checks passed
@steven-sheehy steven-sheehy changed the title Fixing parameter position Fix properties in historical data ingestion documentation Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Type: Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants