-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable log retention in Loki and fix restjava routing #9600
Conversation
Signed-off-by: Steven Sheehy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9600 +/- ##
============================================
- Coverage 92.32% 92.30% -0.02%
Complexity 7413 7413
============================================
Files 911 911
Lines 31050 31469 +419
Branches 3978 3978
============================================
+ Hits 28667 29048 +381
- Misses 1450 1488 +38
Partials 933 933 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Change Prometheus from time based to size based retention * Enable 90 day log retention in Loki * Fix restjava routing broken with Traefik v3 * Fix Traefik dashboard --------- Signed-off-by: Steven Sheehy <[email protected]> (cherry picked from commit 3d493af)
* Change Prometheus from time based to size based retention * Enable 90 day log retention in Loki * Fix restjava routing broken with Traefik v3 * Fix Traefik dashboard --------- Signed-off-by: Steven Sheehy <[email protected]> (cherry picked from commit 3d493af) Signed-off-by: Jesse Nelson <[email protected]>
Enable log retention in Loki and fix restjava routing (#9600) * Change Prometheus from time based to size based retention * Enable 90 day log retention in Loki * Fix restjava routing broken with Traefik v3 * Fix Traefik dashboard --------- (cherry picked from commit 3d493af) Signed-off-by: Steven Sheehy <[email protected]> Signed-off-by: Jesse Nelson <[email protected]> Co-authored-by: Steven Sheehy <[email protected]>
Description:
Related issue(s):
Fixes #9599
Notes for reviewer:
Checklist