Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable log retention in Loki and fix restjava routing #9600

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Oct 17, 2024

Description:

  • Change Prometheus from time based to size based retention
  • Enable 60 day log retention in Loki
  • Fix restjava routing broken with Traefik v3
  • Fix Traefik dashboard

Related issue(s):

Fixes #9599

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <[email protected]>
@steven-sheehy steven-sheehy added enhancement Type: New feature process Build or test related tasks labels Oct 17, 2024
@steven-sheehy steven-sheehy added this to the 0.117.0 milestone Oct 17, 2024
@steven-sheehy steven-sheehy requested a review from a team October 17, 2024 17:54
@steven-sheehy steven-sheehy self-assigned this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (7be3d87) to head (025f788).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9600      +/-   ##
============================================
- Coverage     92.32%   92.30%   -0.02%     
  Complexity     7413     7413              
============================================
  Files           911      911              
  Lines         31050    31469     +419     
  Branches       3978     3978              
============================================
+ Hits          28667    29048     +381     
- Misses         1450     1488      +38     
  Partials        933      933              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edwin-greene
edwin-greene previously approved these changes Oct 17, 2024
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Steven Sheehy <[email protected]>
@steven-sheehy steven-sheehy changed the title Enable log retention in Loki Enable log retention in Loki and fix restjava routing Oct 17, 2024
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Copy link

Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 3d493af into main Oct 17, 2024
35 checks passed
@steven-sheehy steven-sheehy deleted the 9599-loki-retention branch October 17, 2024 21:23
jnels124 pushed a commit that referenced this pull request Oct 17, 2024
* Change Prometheus from time based to size based retention
* Enable 90 day log retention in Loki
* Fix restjava routing broken with Traefik v3
* Fix Traefik dashboard

---------

Signed-off-by: Steven Sheehy <[email protected]>
(cherry picked from commit 3d493af)
jnels124 pushed a commit that referenced this pull request Oct 17, 2024
* Change Prometheus from time based to size based retention
* Enable 90 day log retention in Loki
* Fix restjava routing broken with Traefik v3
* Fix Traefik dashboard

---------

Signed-off-by: Steven Sheehy <[email protected]>
(cherry picked from commit 3d493af)
Signed-off-by: Jesse Nelson <[email protected]>
jnels124 added a commit that referenced this pull request Oct 17, 2024
Enable log retention in Loki and fix restjava routing (#9600)

* Change Prometheus from time based to size based retention
* Enable 90 day log retention in Loki
* Fix restjava routing broken with Traefik v3
* Fix Traefik dashboard

---------


(cherry picked from commit 3d493af)

Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Co-authored-by: Steven Sheehy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki volume filling up
3 participants