Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official web3j gradle plugin #9486

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

kselveliev
Copy link
Contributor

Description:
Use official web3j plugin

This pr adds
buildSrc - remove jitpack dependecy and use the official link of web3j plugin 4.12.2
updated web3j core to 4.12.2

Related issue(s):

Fixes #9485

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev added dependencies Type: Pull requests that update a dependency file web3 Area: Web3 API labels Oct 1, 2024
@kselveliev kselveliev added this to the 0.116.0 milestone Oct 1, 2024
@kselveliev kselveliev self-assigned this Oct 1, 2024
Copy link

sonarqubecloud bot commented Oct 1, 2024

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (19d22d2) to head (7e2e137).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9486   +/-   ##
=========================================
  Coverage     92.57%   92.57%           
  Complexity     7047     7047           
=========================================
  Files           915      915           
  Lines         29870    29870           
  Branches       3773     3773           
=========================================
  Hits          27653    27653           
  Misses         1446     1446           
  Partials        771      771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kselveliev kselveliev marked this pull request as ready for review October 1, 2024 12:05
@kselveliev kselveliev requested a review from a team October 1, 2024 12:05
@steven-sheehy steven-sheehy added the java Pull requests that update Java code label Oct 1, 2024
Copy link
Contributor

@nickeynikolovv nickeynikolovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit b8a6054 into main Oct 1, 2024
33 checks passed
@steven-sheehy steven-sheehy deleted the 09485-official-web3j-plugin branch October 1, 2024 14:56
@steven-sheehy steven-sheehy changed the title feat: Use official web3j gradle plugin Use official web3j gradle plugin Oct 1, 2024
@steven-sheehy steven-sheehy modified the milestones: 0.116.0, 0.115.0 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Type: Pull requests that update a dependency file java Pull requests that update Java code web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use official web3j gradle plugin library
4 participants