Handling numeric values for EntityId query parameters #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mgoelswirlds <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9009 +/- ##
============================================
- Coverage 92.35% 92.25% -0.10%
- Complexity 7515 7535 +20
============================================
Files 909 911 +2
Lines 30237 30305 +68
Branches 3699 3710 +11
============================================
+ Hits 27924 27958 +34
- Misses 1491 1516 +25
- Partials 822 831 +9 ☔ View full report in Codecov by Sentry. |
mgoelswirlds
added
bug
mgoelswirlds
commented
Aug 12, 2024
...-rest-java/src/test/java/com/hedera/mirror/restjava/controller/AllowancesControllerTest.java
Outdated
Show resolved
Hide resolved
steven-sheehy
added
enhancement
steven-sheehy
requested changes
Aug 13, 2024
hedera-mirror-common/src/main/java/com/hedera/mirror/common/domain/entity/EntityId.java
Outdated
Show resolved
Hide resolved
hedera-mirror-common/src/main/java/com/hedera/mirror/common/domain/entity/EntityId.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mgoelswirlds <[email protected]>
steven-sheehy
requested changes
Aug 14, 2024
...or-rest-java/src/test/java/com/hedera/mirror/restjava/common/EntityIdRangeParameterTest.java
Show resolved
Hide resolved
...mirror-rest-java/src/main/java/com/hedera/mirror/restjava/common/EntityIdRangeParameter.java
Outdated
Show resolved
Hide resolved
...-rest-java/src/test/java/com/hedera/mirror/restjava/controller/AllowancesControllerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mgoelswirlds <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes rest-java nft allowance controller to accept numeric entity id in URL params.
This PR modifies ...
shard.realm.numformatRelated issue(s):
Fixes #8357
Notes for reviewer:
Checklist