-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ContractCallNativePrecompileTest #8913
Refactor ContractCallNativePrecompileTest #8913
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8913 +/- ##
=========================================
Coverage 92.20% 92.21%
Complexity 7606 7606
=========================================
Files 925 925
Lines 30451 30451
Branches 3717 3717
=========================================
+ Hits 28076 28079 +3
+ Misses 1549 1546 -3
Partials 826 826 ☔ View full report in Codecov by Sentry. |
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallTestUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallTestUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallTestUtil.java
Outdated
Show resolved
Hide resolved
e99e093
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...rror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallNativePrecompileTest.java
Outdated
Show resolved
Hide resolved
e99e093
to
9cc391a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
…Class Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
e77e9bd
9cc391a
to
e77e9bd
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
With this PR
ContractCallNativePrecompileTest
is now updated to extendWeb3IntegrationTest
instead ofContractCallTestSetup
so that we can delete later the latter one.Fixes #8380