Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ContractCallNativePrecompileTest #8913

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

bilyana-gospodinova
Copy link
Contributor

Description:
With this PR ContractCallNativePrecompileTest is now updated to extend Web3IntegrationTest instead of ContractCallTestSetup so that we can delete later the latter one.

Fixes #8380

@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature test Test infrastructure, automated tests required, etc web3 Area: Web3 API labels Aug 1, 2024
@bilyana-gospodinova bilyana-gospodinova added this to the 0.111.0 milestone Aug 1, 2024
@bilyana-gospodinova bilyana-gospodinova self-assigned this Aug 1, 2024
@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review August 1, 2024 09:15
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (370e379) to head (e77e9bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8913   +/-   ##
=========================================
  Coverage     92.20%   92.21%           
  Complexity     7606     7606           
=========================================
  Files           925      925           
  Lines         30451    30451           
  Branches       3717     3717           
=========================================
+ Hits          28076    28079    +3     
+ Misses         1549     1546    -3     
  Partials        826      826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bilyana-gospodinova bilyana-gospodinova requested a review from a team August 1, 2024 09:20
IvanKavaldzhiev
IvanKavaldzhiev previously approved these changes Aug 1, 2024
Copy link
Contributor

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

edwin-greene
edwin-greene previously approved these changes Aug 1, 2024
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

jascks
jascks previously approved these changes Aug 2, 2024
Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bilyana-gospodinova bilyana-gospodinova force-pushed the 08380-refactor-ContractCallNativePrecompileTest branch from e99e093 to 9cc391a Compare August 5, 2024 06:47
steven-sheehy
steven-sheehy previously approved these changes Aug 5, 2024
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IvanKavaldzhiev
IvanKavaldzhiev previously approved these changes Aug 5, 2024
Copy link
Contributor

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bilyana-gospodinova bilyana-gospodinova force-pushed the 08380-refactor-ContractCallNativePrecompileTest branch from 9cc391a to e77e9bd Compare August 5, 2024 17:34
Copy link

sonarqubecloud bot commented Aug 5, 2024

Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 7e01e72 into main Aug 5, 2024
29 checks passed
@steven-sheehy steven-sheehy deleted the 08380-refactor-ContractCallNativePrecompileTest branch August 5, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature test Test infrastructure, automated tests required, etc web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ContractCallNativePrecompileTest
6 participants