-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log errors generically #8907
Log errors generically #8907
Conversation
Signed-off-by: Jesse Nelson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8907 +/- ##
=========================================
Coverage 92.63% 92.63%
- Complexity 5149 5156 +7
=========================================
Files 689 688 -1
Lines 22207 22226 +19
Branches 2800 2807 +7
=========================================
+ Hits 20571 20590 +19
- Misses 1052 1053 +1
+ Partials 584 583 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jesse Nelson <[email protected]>
hedera-mirror-rest/__tests__/middleware/httpErrorHandler.test.js
Outdated
Show resolved
Hide resolved
hedera-mirror-rest/__tests__/middleware/httpErrorHandler.test.js
Outdated
Show resolved
Hide resolved
verified non rest error thrown by server is caught by handler and when rethrown, the app exits as intended. testing was done by adding below snippet to server.js
|
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
4259b14
to
9da061f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Related issue(s):
Fixes #8895
Notes for reviewer:
Checklist