Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contracts results by hash false alert (0.110) #8902

Conversation

xin-hedera
Copy link
Collaborator

Description:

This PR backports the fix to release/0.110

Related issue(s):

Relates to #8882

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

- only get contracts results by transaction hash for the first successful transaction

Signed-off-by: Xin Li <[email protected]>
@xin-hedera xin-hedera added bug Type: Something isn't working monitor Area: Monitoring and dashboard labels Jul 29, 2024
@xin-hedera xin-hedera added this to the 0.110.0 milestone Jul 29, 2024
@xin-hedera xin-hedera requested a review from a team July 29, 2024 23:24
@xin-hedera xin-hedera self-assigned this Jul 29, 2024
Copy link
Member

@mgoelswirlds mgoelswirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (9b9c4d2) to head (dee1b9a).

Additional details and impacted files
@@               Coverage Diff                @@
##             release/0.110    #8902   +/-   ##
================================================
  Coverage            92.33%   92.33%           
  Complexity            7489     7489           
================================================
  Files                  907      907           
  Lines                30157    30157           
  Branches              3687     3687           
================================================
  Hits                 27844    27844           
  Misses                1492     1492           
  Partials               821      821           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin-hedera xin-hedera merged commit 2baba30 into release/0.110 Jul 30, 2024
29 checks passed
@xin-hedera xin-hedera deleted the 8882-false-alert-in-new-monitor-contracts-results-check-110 branch July 30, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working monitor Area: Monitoring and dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants