Fix address book bootstrap failing with null ip_address_v4
#8851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mgoelswirlds <[email protected]>
mgoelswirlds
added
bug
mgoelswirlds
requested review from
a team and
edwin-greene
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8851 +/- ##
============================================
+ Coverage 92.18% 92.20% +0.01%
- Complexity 7597 7598 +1
============================================
Files 925 925
Lines 30377 30407 +30
Branches 3684 3694 +10
============================================
+ Hits 28003 28036 +33
+ Misses 1548 1545 -3
Partials 826 826 ☔ View full report in Codecov by Sentry. |
|
Needs a test that reproduces the issue. |
steven-sheehy
changed the title
ip_address_v4
- Adding tests. Signed-off-by: mgoelswirlds <[email protected]>
|
...mporter/src/test/java/com/hedera/mirror/importer/addressbook/AddressBookServiceImplTest.java
Show resolved
Hide resolved
steven-sheehy
approved these changes
Jul 23, 2024
bilyana-gospodinova
pushed a commit
that referenced
this pull request
Jul 24, 2024
Adding back, throwing exception for invalid IP. --------- Signed-off-by: mgoelswirlds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR sets ip_address_v4 to an empty string.
This PR
Related issue(s):
Fixes #8844
Notes for reviewer:
Checklist