Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Citus coordinator replication mode to sync-all #8841

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Jul 22, 2024

Description:

  • change replication mode to sync-all

Related issue(s):

Fixes #8752

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added bug Type: Something isn't working database Area: Database labels Jul 22, 2024
@jnels124 jnels124 added this to the 0.110.0 milestone Jul 22, 2024
@jnels124 jnels124 requested review from a team and jascks and removed request for a team July 22, 2024 13:44
@jnels124 jnels124 linked an issue Jul 22, 2024 that may be closed by this pull request
@jnels124 jnels124 requested review from a team and removed request for jascks July 22, 2024 13:44
@jnels124 jnels124 marked this pull request as draft July 22, 2024 13:48
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (aea6981) to head (afed97c).
Report is 146 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8841      +/-   ##
============================================
- Coverage     92.61%   92.18%   -0.44%     
- Complexity     5149     7597    +2448     
============================================
  Files           689      925     +236     
  Lines         22153    30377    +8224     
  Branches       2774     3684     +910     
============================================
+ Hits          20517    28003    +7486     
- Misses         1052     1548     +496     
- Partials        584      826     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy changed the title Change Replication Mode Change Citus coordinator replication mode to sync-all Jul 22, 2024
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 marked this pull request as ready for review July 22, 2024 17:27
@jnels124 jnels124 merged commit 6046505 into main Jul 22, 2024
31 checks passed
@jnels124 jnels124 deleted the 8752-citus-replica-consistency-issue branch July 22, 2024 18:22
@steven-sheehy steven-sheehy added the citus Area: Citus label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working citus Area: Citus database Area: Database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citus Replica Consistency Issue
4 participants