-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix value of v in contract result APIs for legacy Ethereum transactions #8632
Conversation
Signed-off-by: Steven Sheehy <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8632 +/- ##
============================================
+ Coverage 92.39% 92.40% +0.01%
Complexity 7489 7489
============================================
Files 914 914
Lines 29856 29860 +4
Branches 3641 3644 +3
============================================
+ Hits 27585 27592 +7
+ Misses 1445 1442 -3
Partials 826 826 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG 🙌🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Description:
Fix the return value of v in the contract results APIs to use the actual
signature_v
field instead ofrecovery_id
for legacy Ethereum transactions.Related issue(s):
Fixes #8597
Notes for reviewer:
Checklist