Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of v in contract result APIs for legacy Ethereum transactions #8632

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

steven-sheehy
Copy link
Member

Description:

Fix the return value of v in the contract results APIs to use the actual signature_v field instead of recovery_id for legacy Ethereum transactions.

Related issue(s):

Fixes #8597

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added bug Type: Something isn't working rest Area: REST API labels Jun 24, 2024
@steven-sheehy steven-sheehy added this to the 0.108.0 milestone Jun 24, 2024
@steven-sheehy steven-sheehy self-assigned this Jun 24, 2024
Copy link

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (035e078) to head (1850a64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8632      +/-   ##
============================================
+ Coverage     92.39%   92.40%   +0.01%     
  Complexity     7489     7489              
============================================
  Files           914      914              
  Lines         29856    29860       +4     
  Branches       3641     3644       +3     
============================================
+ Hits          27585    27592       +7     
+ Misses         1445     1442       -3     
  Partials        826      826              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 🙌🏾

Copy link

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@steven-sheehy steven-sheehy merged commit f695be9 into main Jun 24, 2024
31 checks passed
@steven-sheehy steven-sheehy deleted the 8597-fix-legacy-signature-v branch June 24, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working rest Area: REST API
Projects
None yet
5 participants