Rest API redis error: wrong number of arguments for 'mget' command #8606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Schmidt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8606 +/- ##
============================================
- Coverage 92.52% 92.40% -0.13%
- Complexity 7372 7489 +117
============================================
Files 895 914 +19
Lines 29553 29856 +303
Branches 3610 3641 +31
============================================
+ Hits 27345 27588 +243
- Misses 1387 1442 +55
- Partials 821 826 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jeff Schmidt <[email protected]>
Signed-off-by: Jeff Schmidt <[email protected]>
steven-sheehy
approved these changes
Jun 24, 2024
|
jascks
deleted the
8587-rest-api-redis-error-wrong-number-of-arguments-for-mget-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It appears the following redis error happens quite frequently in
testnet:If the keys provided to
mget(),mgetBuffer()etc are empty, then the behavior is to throw this error. There are a few opportunities fortransactions.getTransactionTimestamps()to return empty rows. It seems reasonable forcache.get()to look for this condition.Related issue(s):
Fixes #8587
Notes for reviewer:
Checklist