fix(matrix): stop retry loop on token introspection auth errors - #921
Open
hashbender wants to merge 1 commit into
Open
fix(matrix): stop retry loop on token introspection auth errors#921hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Matrix sync loop so mautrix token introspection failures are treated as permanent auth errors instead of transient sync errors retried forever.
The adapter already stopped on 401/403/unauthorized/forbidden and unknown-token responses; this adds the observed
Unable to introspect the access tokenfailure mode to the same classification and shares that classification between returned sync error objects and thrown exceptions.Related Issue
Fixes NousResearch#56532
Type of Change
Changes
Unable to introspect the access tokenas a permanent auth condition.How to Test
.venv/bin/python -m pip install aiohttp(local test dependency needed by existing Mattermost tests in the same file).venv/bin/python -m pytest tests/gateway/test_ws_auth_retry.py -q.venv/bin/python -m ruff check plugins/platforms/matrix/adapter.py tests/gateway/test_ws_auth_retry.pyscripts/run_tests.sh tests/gateway/test_ws_auth_retry.py -qpytest tests/ -qPlatform: macOS, Python 3.13, local
.venv.Mirror-of: NousResearch#57150
NousResearch#57150