fix(auth): surface real upstream 429 when all pool entries exhausted (#40960) - #912
Open
hashbender wants to merge 1 commit into
Open
fix(auth): surface real upstream 429 when all pool entries exhausted (#40960)#912hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #40960: when all credential pool entries are in exhaustion cooldown (e.g. after a 429 quota-exhausted response),
_resolve_api_key_provider_secret()silently returned an emptyapi_key. This caused the API request to fail with a misleading 401 Unauthorized, hiding the real cause (a 429 quota message from the provider).Root Cause
hermes_cli/auth.pyL593-605: whenpool.peek()returnsNone(all entries in cooldown), the code returns an empty string forapi_keyinstead of falling back to an exhausted entry.Fix
After
peek()returnsNone, iteratepool._entriesand return the first usable key with a warning log. The upstream API then returns its real 429 with the quota-reset timestamp, giving users actionable information.Test Plan
ast.parse()passesRelated
Mirror-of: NousResearch#57137
NousResearch#57137