fix(desktop): show Hindsight local embedded mode - #903
Open
hashbender wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local_embeddedto the Hindsight mode options exposed by the desktop memory-provider settings schema.local_embeddedconfig is displayed and preserved instead of being coerced tocloud.Why
A valid Hindsight config can use
mode: local_embedded, but the desktop config surface only allowedcloudandlocal_external. The web endpoint therefore treatedlocal_embeddedas an unsupported select value and fell back to the defaultcloud, making the settings panel misleading and risking an accidental save back to cloud mode.There is a broader schema-driven memory-provider PR open (NousResearch#48675). This is the small surgical fix for the current production bug, so users with local embedded Hindsight are not shown the wrong mode while that larger refactor is reviewed.
Test Plan
python -m pytest tests/hermes_cli/test_memory_providers.py tests/hermes_cli/test_web_server.py -q— 342 passedpython -m ruff check hermes_cli/memory_providers.py tests/hermes_cli/test_memory_providers.py tests/hermes_cli/test_web_server.py— passednpm run typecheckfromapps/desktop— passednpx vitest run --environment jsdom src/app/settings/provider-config-panel.test.tsxfromapps/desktop— 5 passedMirror-of: NousResearch#57126
NousResearch#57126