feat(gateway): add 'log' option to display.tool_progress (#3459 salvage) - #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display.tool_progress: log— a fifth mode that keeps the chat completely silent while appending every tool call as a timestamped line to~/.hermes/logs/tool_calls.log, giving gateway operators an audit trail without chat noise.Salvage of NousResearch#3459 by @keslerm, reimplemented against the restructured progress-callback block (resolve_display_setting / needs_progress_queue / thinking-relay landed since March). Duplicate NousResearch#3458 by @dlkakbs was submitted 4 minutes earlier with the same feature — credited via Co-authored-by.
Changes
gateway/run.py:log_queue+ log branch inprogress_callback(tool.started only,_thinkingexcluded),write_tool_log()async drain with RotatingFileHandler (5MB × 3) +RedactingFormatter(secrets never land on disk), task lifecycle (start/cancel/await); chat progress stays disabled in log mode, thinking_progress relay unaffectedgateway/slash_commands.py+locales/en.yaml:/verbosecycles off → new → all → verbose → loghermes_cli/{commands,setup,config}.py,cli-config.yaml.example: descriptions + validationtest_tool_log_mode.py(7 tests),test_verbose_command.pycycle updatedValidation
Infographic
Nous Research
Mirror-of: NousResearch#57014
NousResearch#57014