fix(backup): guard os.chmod on Windows where it is a no-op - #764
Open
hashbender wants to merge 1 commit into
Open
fix(backup): guard os.chmod on Windows where it is a no-op#764hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the backup import test failure on Windows where
os.chmod(target, 0o600)is a silent no-op. On Windows,os.chmodwith Unix permission bits succeeds without error but doesn't change anything — the file stays at default0o666permissions.Extracts a
_tighten_file_permissions()helper that skips the chmod on Windows (NTFS ACLs already restrict newly-created files to the owner / SYSTEM / Administrators), and makes the test assertion platform-aware.Related Issue
Fixes NousResearch#56923
Type of Change
Changes Made
hermes_cli/backup.py: Added_tighten_file_permissions()helper that wrapsos.chmod(path, 0o600)with asys.platform == "win32"guard. Replaced both bareos.chmodcalls (line 604 and 648) with the helper.tests/hermes_cli/test_backup.py: Addedimport sysand wrapped thest_mode & 0o777 == 0o600assertion inif sys.platform != "win32":so the test passes on both POSIX and Windows.How to Test
pytest tests/hermes_cli/test_backup.py::TestMemoryProviderExternalPaths::test_import_restores_external_to_home_relative_location -xvs— should passassert (33206 & 511) == 384)pytest tests/hermes_cli/test_backup.py -q— all 145 tests should pass (verified on macOS)Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Before (Windows):
After (macOS/Linux):
Mirror-of: NousResearch#56946
NousResearch#56946