Skip to content

fix: replace bash array syntax with POSIX sh compatible code in stage… - #709

Open
hashbender wants to merge 1 commit into
mainfrom
mirror/pr-56870
Open

fix: replace bash array syntax with POSIX sh compatible code in stage…#709
hashbender wants to merge 1 commit into
mainfrom
mirror/pr-56870

Conversation

@hashbender

Copy link
Copy Markdown
Owner

…2-hook.sh The script uses #!/bin/sh but used bash-specific array syntax (()) for _merge_args, causing 'Syntax error: (" unexpected' on systems where /bin/sh is not bash (e.g. dash). Replace with POSIX-compatible set -- "$@" pattern.

Removed redundant directory creation and ownership checks for HERMES_HOME in rootless environments. Updated comments to clarify behavior in rootless scenarios.

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs


Mirror-of: NousResearch#56870
NousResearch#56870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant