fix(browser): guard Camofox eval private pages - #625
Open
hashbender wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends the browser private-network eval guard to the Camofox backend.
Recent browser hardening closed the eval/private-page leak for the normal browser paths, but
_browser_eval()returned early in Camofox mode before running the shared private URL literal pre-scan and before re-checking the current page URL after eval. That left Camofox as a sibling backend that could still executebrowser_console(expression=...)against private/internal targets.This PR routes Camofox eval through the same guard shape:
window.location.hrefRelated Issue
Follow-up to the browser private-network hardening in NousResearch#56173, NousResearch#56526, and NousResearch#56664.
Type of Change
Changes Made
tools/browser_tool.pytests/tools/test_browser_eval_ssrf.pyHow to Test
python -m pytest tests/tools/test_browser_eval_ssrf.py::TestCamofoxEvalGuard -qpython -m pytest tests/tools/test_browser_eval_ssrf.py::TestCamofoxEvalGuard tests/tools/test_browser_eval_ssrf.py::TestExpressionPreScan tests/tools/test_browser_eval_ssrf.py::TestPostEvalPageRecheck -qpython -m pytest tests/tools/test_browser_eval_ssrf.py tests/tools/test_browser_snapshot_ssrf.py tests/tools/test_browser_private_page_action_guard.py tests/tools/test_browser_cdp_tool.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
Mirror-of: NousResearch#56764
NousResearch#56764