fix(qqbot): add missing is_reconnect parameter to QQAdapter.connect() - #607
Open
hashbender wants to merge 1 commit into
Open
hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
BasePlatformAdaptercontract requiresconnect()to accept anis_reconnectkeyword argument, forwarded from the gateway reconnect watcher. The QQ adapter'sconnect()signature didn't include it, causing aTypeErroron reconnect attempts.Fix
Added
is_reconnect: bool = Falseas a keyword-only parameter toQQAdapter.connect(). The parameter is not currently used by the QQ adapter internally, but accepting it satisfies theBasePlatformAdaptercontract and prevents a crash when the gateway attempts to reconnect a dropped QQ bot session.Mirror-of: NousResearch#56740
NousResearch#56740