fix(cli): use CON device instead of /dev/tty on Windows - #594
Open
hashbender wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a Windows-specific compatibility issue where
_reset_terminal_input_modes_on_exit()fails withFileNotFoundErrorbecause Windows doesn't have/dev/ttydevice.Related Issue
This is a split from PR NousResearch#54933 (closed). The
local.pychanges were identified as duplicates of NousResearch#49460 and NousResearch#54235, but thiscli.pyfix is independent and not covered by those PRs.Type of Change
Changes Made
_reset_terminal_input_modes_on_exit()to useCONdevice on Windows instead of/dev/ttyHow to Test
FileNotFoundErroris raised/dev/ttystill works on Linux/macOSChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass (Note: Full test suite not run due to environment limitations)Documentation & Housekeeping
cli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/ANote: Part of this code was AI-assisted, reviewed and tested by human.
Mirror-of: NousResearch#56722
NousResearch#56722