fix: hashlib.md5 FIPS crash in context_compressor.py - #588
Open
hashbender wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashlib.md5()incontext_compressor.pyis used for content deduplication (hashing tool outputs to detect duplicates). On FIPS-enabled systems (RHEL 8/9, CentOS with FIPS mode), this raises:Root Cause
Line 1229 calls
hashlib.md5()withoutusedforsecurity=False. OpenSSL in FIPS mode rejects MD5 for any use unless explicitly marked as non-security.Fix
Added
usedforsecurity=Falseparameter to thehashlib.md5()call. This hash is used solely for content deduplication — no security implications.Changes
agent/context_compressor.py:hashlib.md5(...)→hashlib.md5(..., usedforsecurity=False)Test Plan
Mirror-of: NousResearch#56715
NousResearch#56715