fix: avoid 500 when password-only auth provider hits /auth/login - #553
Open
hashbender wants to merge 1 commit into
Open
hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard login flow calls
GET /auth/login?provider=<name>for interactive providers. Inhermes_cli/dashboard_auth/routes.py,auth_login()unconditionally callsp.start_login(...)once the provider exists andsupports_sessionis true.That breaks for
BasicAuthProvider, whosestart_login()intentionally raises:Result: clicking the dashboard login button for the basic/password provider returns 500 Internal Server Error instead of a clean client error, and the stack trace bubbles all the way to ASGI.
Root cause
auth_login()only catchesProviderError, butBasicAuthProvider.start_login()raisesNotImplementedError, so the request falls through as an unhandled exception.Fix
GET /auth/loginwith a clean400explaining that the client mustPOST /auth/password-logininstead.NotImplementedErrordefensively and convert it into a400rather than a 500.This preserves the intended split:
GET /auth/loginPOST /auth/password-loginRepro
/login.BasicAuthProvider is password-only; there is no OAuth redirect flow.Mirror-of: NousResearch#56666
NousResearch#56666