fix(slack): harden rich table block fallback - #513
Open
hashbender wants to merge 1 commit into
Open
Conversation
|
Review Complete Risk: 🟢 Low (15/100) — no findings · 214 LOC across 4 files PR adds retry logic to Slack adapter for block-payload rejections and refines Block Kit column_settings rendering. One low-confidence finding was identified below threshold (dead error code in block-rejection detection targeting wrong Slack API surface). Files Reviewed (4 files) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a live Slack API regression from the merged NousResearch#56102
rich_blockstable path.This keeps the selected Block Kit renderer architecture intact and makes a narrow schema/fallback hardening change:
column_settings, nevernullcolumn_settingsentries so Slack applies defaultsblockswhen Slack rejects a rich Block Kit payload as invalid/too largeFixes NousResearch#56615
cc @teknium1, this is the focused follow-up from the live validation comment on NousResearch#56102.
Validation
Notes
This intentionally does not port the broader NousResearch#53893 hardening set. Those can be separate follow-ups. This PR only fixes the current merged table-block regression and prevents rich formatting failures from dropping Slack replies.
Mirror-of: NousResearch#56618
NousResearch#56618