fix(web): redact extracted content before truncate-store - #44
Open
hashbender wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This redacts secrets from
web_extractprovider content before the new truncate-and-store path returns it to the model or writes the full page copy tocache/web.Why
After NousResearch#54843,
web_extractreturns clean provider content directly instead of sending every page through an auxiliary LLM summarizer. That fast path still blocks secrets embedded in the URL, but it did not redact secrets present in the extracted page body.As a result, if a backend returns page text containing values like
OPENAI_API_KEY=sk-..., the raw secret can be included in the tool result sent to the model. For large pages, the same raw content can also be written into the stored full-text cache file used for paging.Changes
redact_sensitive_text(..., force=True)after base64 image cleanup and before truncate/store processing.cache/webfull-text copy.web_extractresponse or the stored full-text file.Tests