feat(lsp): add PowerShellEditorServices language server - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hermes now provides semantic diagnostics for PowerShell files (
.ps1/.psm1/.psd1) by wiring PowerShellEditorServices into the LSP server registry.PSES is not a single PATH binary — it's a PowerShell module bundle launched by a
pwsh/powershellhost viaStart-EditorServices.ps1. It ships as a GitHub release zip (no npm/go/pip recipe), so it sits in the manual install tier alongsiderust-analyzerandclangd.Changes
agent/lsp/servers.py: register thepowershellserver — extensions,powershelllanguage IDs, a root resolver (PSScriptAnalyzer settings → git workspace), a bundle-locator, and a stdio spawn builder that launchespwsh -NoProfile -NonInteractive ... Start-EditorServices.ps1 -Stdio.agent/lsp/install.py: manual-tier recipe sohermes lsp status/listreport it (probes thepwshhost).website/docs/user-guide/features/lsp.md: supported-servers row + a PowerShell setup section.tests/agent/lsp/test_powershell_server.py: 8 tests (routing, language IDs, skip-without-pwsh, skip-without-bundle, command construction, override precedence,bundlePathnot leaked into init options).Bundle resolution order:
lsp.servers.powershell.commandoverride → initbundlePath→PSES_BUNDLE_PATHenv →<HERMES_HOME>/lsp/PowerShellEditorServices.Validation
.ps1/.psm1/.psd1route topowershell, spawn command built correctly,lsp status→installedoncepwshfoundInfographic
Nous Research
Mirror-of: NousResearch#55930
NousResearch#55930