fix: add encoding="utf-8" to Path.write_text() calls (P1) - #331
Open
hashbender wants to merge 1 commit into
Open
fix: add encoding="utf-8" to Path.write_text() calls (P1)#331hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit
encoding="utf-8"to 39Path.write_text()calls across 16 files.Problem
Path.write_text()without encoding defaults to system locale. On Windows (cp1252), this corrupts non-ASCII content. Same root cause as PLW1514 but for the write path.This is the write-side counterpart to the read_text() encoding fix (PR NousResearch#56115).
Changes (16 files, 39 instances)
Testing
All 16 files pass py_compile verification. Zero duplicate encodings.
Mirror-of: NousResearch#56385
NousResearch#56385