fix(runtime): honor NOUS_INFERENCE_BASE_URL across pool/explicit/aux paths (salvage #55198) - #201
Open
hashbender wants to merge 1 commit into
Open
fix(runtime): honor NOUS_INFERENCE_BASE_URL across pool/explicit/aux paths (salvage #55198)#201hashbender wants to merge 1 commit into
hashbender wants to merge 1 commit into
Conversation
|
Review Complete Risk: 🟢 Low (12/100) — no findings · 123 LOC across 5 files No issues found in this PR. The changes to auxiliary_client.py and runtime_provider.py are well-structured refactors and test additions with no regressions, security vulnerabilities, or data-handling concerns. Files Reviewed (5 files) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Salvage of NousResearch#55198 by @counterposition (Harish Kukreja) onto an org-owned branch. His commit is cherry-picked verbatim (authorship preserved); this PR exists only so the arm64 Docker build gets a token with
packages: write.Why salvage instead of a re-run: NousResearch#55198 is a fork PR (
counterposition/hermes-agent). ItsBuild&Test Docker image / build-arm64check fails withdenied: installation not allowed to Write organization package— fork PRs get a read-onlyGITHUB_TOKENfor org packages by design, so re-running the fork PR fails identically every time. Every other check on NousResearch#55198 is green (all 8 test slices, e2e, ruff, ty, uv.lock). Running the same commit from an org branch clears the package-write permission.The fix (unchanged from NousResearch#55198)
NousResearch#52270 added
_nous_inference_env_override()soNOUS_INFERENCE_BASE_URLcan point a Nous OAuth session at a self-hosted / staging inference endpoint, but only wired it intoresolve_nous_runtime_credentials. Three sibling resolution paths still dropped the override:_resolve_runtime_from_pool_entry(hermes_cli/runtime_provider.py)_resolve_explicit_runtime(hermes_cli/runtime_provider.py)_pool_runtime_base_url(agent/auxiliary_client.py)This routes all three through the same auth-layer reader, so every
NOUS_INFERENCE_BASE_URLread shares one normalization + trusted-bypass path. Live-only invariant preserved: the override wins for the base URL returned this run but is never persisted toauth.jsonor the credential pool.Verification
Cherry-picked cleanly onto current
main(56d4bfe4b). PR's own suites re-run on the merged tree: 97 passed (tests/hermes_cli/test_runtime_provider_resolution.py,test_auth_nous_provider.py,tests/agent/test_auxiliary_client.py), including the pool/explicit/aux override tests and the live-not-persisted invariant.Attribution
Co-authored-by preserved from the original commit. Full credit to @counterposition — closing NousResearch#55198 in favour of this once merged.
Salvages NousResearch#55198.
Mirror-of: NousResearch#56122
NousResearch#56122