Skip to content

fix(gateway): guard NoneType in Telegram reconnect after network error (#55992) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hashbender wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(gateway): guard NoneType in Telegram reconnect after network error (#55992) #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions plugins/platforms/telegram/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1781,6 +1781,18 @@ async def _handle_polling_network_error(self, error: Exception) -> None:

await self._drain_polling_connections()

# Guard against self._app being torn down by the supervisor while
# we were sleeping during the reconnect delay. The stop() call
# above is already guarded but start_polling() was not — accessing
# self._app.updater when self._app is None raises AttributeError
# and silently kills the reconnect loop. (#55992)
if not self._app or not self._app.updater:
logger.warning(
"[%s] Telegram app destroyed during reconnect delay (attempt %d) — aborting",
self.name, attempt,
)
return

try:
await self._app.updater.start_polling(
allowed_updates=Update.ALL_TYPES,
Expand Down
Loading