Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling changes to the profile calendar widget #2019

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

anishTP
Copy link
Contributor

@anishTP anishTP commented Apr 16, 2024

No description provided.

@jace
Copy link
Member

jace commented Apr 27, 2024

Issues in mobile view:

  1. The filter icon is not aligned with the right chevron.
  2. Some extraneous element is on the right side of the calendar.
  3. The Projects list has a white patch below.

imageimage

@jace
Copy link
Member

jace commented Apr 27, 2024

In desktop view, the calendar has a white frame visible at bottom.

image

The event label needs to be offset upwards a bit so it doesn't overlap with the date digits of the next row.

@jace
Copy link
Member

jace commented May 1, 2024

Widget issues:

  • Left side: Left chevron and label aren't visually aligned
  • Right side: Chevrons have hover+active state that stays after a click, but filter icon doesn't have it. Hover+active state is not required here.
  • Chevron tap targets are reduced from before, which may be an issue on mobile
  • Calendar days have an underline on hover but aren't clickable (see day 1)
  • Label text continues to overlap day numbers on the next line
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants