Bugfix: allow follower to be made account admin (fixes #2095) (#2096)

Or, why tests are really needed! Too rushed today for that.
hasgeek · Jul 12, 2024 · f77f93d · f77f93d
1 parent 193d966
commit f77f93d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/funnel/views/membership.py b/funnel/views/membership.py
@@ -116,9 +116,11 @@ def new_member(self) -> ReturnView:
                             'error_description': _("This user is already an admin"),
                             'errors': membership_form.errors,
                         }, 422
-                    with previous_membership.amend_by(current_auth.user) as amendment:
-                        membership_form.populate_obj(amendment)
-                    new_membership = amendment.membership
+                    new_membership = previous_membership.replace(
+                        actor=current_auth.user,
+                        is_owner=membership_form.is_owner.data,
+                        is_admin=True,
+                    )
                 else:
                     new_membership = AccountMembership(
                         account=self.obj, granted_by=current_auth.user, is_admin=True