Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUI changes #195

Merged
merged 11 commits into from
Sep 10, 2018
Merged

MUI changes #195

merged 11 commits into from
Sep 10, 2018

Conversation

vidya-ram
Copy link
Member

  1. Add styling for responsive table in larger screen sizes.
  2. Add helper classes ( mui-list--aligned, mui--d-inlineblock)
  3. Remove the scroll lock class added by mui.js on opening select menu. Fixes the body scroll lock for select2
  4. Minor css fixes for mui-form

@vidya-ram vidya-ram changed the title Mui responsive table MUI changes Sep 4, 2018
jace
jace requested changes Sep 7, 2018
View reviewed changes
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SCSS files need correct linting. One <p> tag is incorrect. The :not selector needs to be deprecated in a separate ticket. Apart from these minor issues, all good.

baseframe/static/js/baseframe-material.js Show resolved Hide resolved
baseframe/static/sass/baseframe-material/_layout.scss Outdated Show resolved Hide resolved
baseframe/static/sass/baseframe-material/_modal.scss Outdated Show resolved Hide resolved
baseframe/templates/baseframe/mui/forms.html.jinja2 Outdated Show resolved Hide resolved
@vidya-ram vidya-ram merged commit dc2be95 into master Sep 10, 2018
@vidya-ram vidya-ram deleted the mui-responsive-table branch September 10, 2018 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jace jace jace requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vidya-ram @jace