-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
features, fixes and style changes #18
base: master
Are you sure you want to change the base?
Conversation
Fix the checking of costmap_clearing_threshold parameter if the frontier grid cell value is updated. The goal is cancelled. Minor timing adjustments are also added during infinite loops, in order to not hog the processor. Furthermore formatting is improved.
A small delay is added inside infinite while loop in order to not hog the processor. Furthermore, code is formatted.
…ition The function is modified without changing it's name to also return the robot orientation, apart from the position.
When the user specify the exploration region using Rviz by clicking on the map, the clicked points are displayed on the terminal. Furthermore, code is formatted.
Thank you very much for your changes and the time you put in it, I appreciate that a lot. I still haven't checked all your changes, it is hard to track the code changes because they are mixed with formatting changes, when I check file changes, Git marks all the lines as changed, and now it's very hard to check which lines have actually been changed. That's not a problem though, but would appreciate in future PRs (I hope 😉 ), if you separate code changes from formatting... I run your changes, and there are few problems:
|
I had made changes in my local repo. Since, I was waiting for the previous pull request to be finished and was not able to push further changes, therefore, today I have tried to break them as much as possible (:smile: ).
|
Once the PR is ready, I will merge it 👍 |
I have add some new features, minor adjustments and improved code readability.