Input events #2697
Input events #2697
Conversation
|
PS: If you really want, it's easy to update the library, but then it has to be stated that only the one you specify has to be used... |
| @@ -510,3 +510,7 @@ class Chosen extends AbstractChosen | |||
| w = f_width - 10 | |||
|
|
|||
| @search_field.css({'width': w + 'px'}) | |||
|
|
|||
| form_field_has_changed: (extra) -> | |||
There was a problem hiding this comment.
Even if we're not going to support the input event in the prototype version I think we still should extract the change trigger to a method, just like is done here.
There was a problem hiding this comment.
Also I'm not sure about the name of the method. More leaning to trigger_form_field_change, but maybe some of @harvesthq/chosen-developers can weigh in on this matter?
There was a problem hiding this comment.
trigger_form_field_change was my first idea 😄, I thought it might be best to be a bit less specific in the name, but I'm fine with that name too.
You don't use _myPrivateMethod for private/protected methods, right? It's not really a public method.
|
|
||
| #### Running tests | ||
|
|
||
| To install all development dependencies, in the project's root directory, run |
There was a problem hiding this comment.
This is redundant, as it is already stated above.
There was a problem hiding this comment.
It is indeed. As an experienced dev, the only thing I'm interested in is how do I get to run the tests. For this reason, I thought a separate (and independant) section was better. I probably chose the wrong header size. Let me tweak it and split this into another PR.
marcandre
force-pushed
the
input_events
branch
from
720cd26 to
e53658b
Compare
|
OK, PR updated, with factorization done for prototype's version too. |
|
@marcandre would it be easily possible to feature-test the prototype version to see if it has support for |
|
The only way would be to know is to try to call The lib isn't all that useful anyways... Want a PR to get rid of it? |
|
PR created, getting rid of |
|
@koenpunt This looks good to me — if you're 👍 , I'm 👍 |
|
@marcandre Do you mind squashing this down to one commit? Instructions if needed. |
|
Closing in favor of #2704 |
While not widely known, the
inputevent is triggered before allchangeevents for inputs and selects (see the spec here)This PR fixes this. Also adds a blurb on how to run tests...
I haven't changed the prototype version because it uses an old library that does not support the
inputevent. Last commit was 4 years ago, looks like abandonware.FWIW,
Parsleyrelies on theinputevent, so the current code is causing bad interactions.Thanks