Fix choice build after update #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because ``this.choices_count`` was getting called after ``@selected_option_count = null``, this condition NEVER passed.
|
looks good to me |
|
|
pfiller
added a commit
that referenced
this pull request
Jul 2, 2013
Replace prop for jQuery legacy support #1311 Prevent default on arrow down #1309 Explicitly add files for gh-pages #1307 Fix RTL Disabled Search Issue #1300 Fix scroll bug in Prototype version #1301 Read-only search field when search is disabled. #1294 Remove Grunt-Bump #1280 Make sure Chosen isn't disabled before showing results. #1282 Fix choice build after update #1286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenearley @stof Another easy bug fix.
This resolves #1270. Essentially, the condition here wasn't testing the proper value. We can safely clear all choices as we're already re-building choices at a later point.
(btw, my commit message on 3e0fbf7 is wrong, but the sentiment is rightish)