Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #202 - width discrepency for firefox #1170

Closed
wants to merge 1 commit into from

Conversation

kevnk
Copy link

@kevnk kevnk commented Apr 26, 2013

I simply switched the order of the if statement to use jquery first if available because it's more reliable (and works for FF) than the raw javascript (which didn't work for firefox)

…te first if available b/c it's more reliable than the raw javascript route apparently
@pfiller
Copy link
Contributor

pfiller commented Apr 26, 2013

Thanks @kevinkirchner. The way you fixed this meant that Prototype was still getting the broken version. It also made the window.computedStyle call totally unnecessary in the jQuery version.

After you shared this, I did some digging and I think offsetWidth may be a safe and reliable option. I've opened #1172 which seems to solve the FF issue and gives us a cleaner method. Mind taking a look to make sure it solves the problem you were seeing?

@pfiller pfiller closed this Apr 26, 2013
@kevnk
Copy link
Author

kevnk commented Apr 29, 2013

Commit be1a255 does indeed solve out Firefox issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants