-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Select: .search-field input
width does not fill width of .chosen-choices
#1729
Comments
What browser, browser version, OS, and OS version are you using? |
I'm pretty confident this issue manifests independent of browser/OS, but here's a few combinations with which I've reproduced it:
|
@jordanstephens Okay, thanks for the report. The @harvesthq/chosen-developers are the final say, but pull requests are always welcome! |
Alright, I'll put something together. |
I'd love to see this merged in. This is a fairly serious usability issue when trying to delete a previous selection. If you click on the perceived field outside of the text box, focus blurs. If you then press the delete key, it triggers the browser's back action (since the input doesn't have focus), potentially losing whatever other work you've done so far on the page. We saw this happen to one of our users during a recent round of usability testing. |
Calling activate_field on choices_click, fixes #1729
For Multiple Select, the width of
.search-field input
does not fill the width of the perceived input of.chosen-choices
.This is illustrated clearly in the following screenshot from the Chosen demo page at http://harvesthq.github.io/chosen/
This really becomes a problem when a user attempts to click inside the perceived input field after the field has been given focus. This actually causes the real input field to lose focus and potentially causes a lot of confusion for the user when clicking inside what looks like an input field doesn't actually give it focus.
It looks like there was a small mention of this issue in this thread (#407 (comment)), but it doesn't look like it was ever truly addressed.
Steps to reproduce:
Possible Solutions
.chosen-choices
minus the width of any already selected values. We probably want to give the input some minimum width also, to prevent it from becoming confusingly narrow.input
on any click events on.chosen-choices
.Is there any interest in merging a solution to this issue? I'd be happy to cook up a pull request with either of the above solutions.
The text was updated successfully, but these errors were encountered: