Skip to content

Comments

Upgrade to latest requests...#2867

Merged
bensteinberg merged 1 commit intoharvard-lil:developfrom
rebeccacremona:upgrade-package
Oct 28, 2020
Merged

Upgrade to latest requests...#2867
bensteinberg merged 1 commit intoharvard-lil:developfrom
rebeccacremona:upgrade-package

Conversation

@rebeccacremona
Copy link
Contributor

@rebeccacremona rebeccacremona commented Oct 28, 2020

....and unpin urllib (which was pinned for requests 2.2…0.0).

And upgrade unpinned packages.

The latest version of requests includes what sounds like a big change to SSL handling:

pyOpenSSL TLS implementation is now only used if Python either doesn’t have an ssl module or doesn’t support SNI. Previously pyOpenSSL was unconditionally used if available. This applies even if pyOpenSSL is installed via the requests[security] extra (#5443)

They are deprecating requests[security], which we currently use. To be investigated: why, and can we just stop?

Hopefully this will not affect captures at all, but I'll keep my eye out for problems.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.462% when pulling 6f2818e on rebeccacremona:upgrade-package into 3d9f64e on harvard-lil:develop.

@bensteinberg bensteinberg merged commit 346bf63 into harvard-lil:develop Oct 28, 2020
@rebeccacremona rebeccacremona deleted the upgrade-package branch December 2, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants