Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Void Linux support and change the way UEFI image is loaded in qemu. #172

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

Animeshz
Copy link
Contributor

@Animeshz Animeshz commented May 9, 2023

  • Added candidate /usr/share/qemu/edk2-x86_64-code.fd as a search path for OVMF image.
  • Changed -bios with -drive, with the old -bios option, it was qemu: could not load PC BIOS '/usr/share/qemu/edk2-x86_64-code.fd'.

I believe I found this format of specifying uefi image from this article, in the "Testing" part.


Example:

23-05-09-22h29m22s

Copy link
Owner

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Animeshz that's a nice pull request! 👍

There are three details that I would like to bring up for discussion:

  • Should we add the readonly flag? (I came across it at https://wiki.archlinux.org/title/Unified_Extensible_Firmware_Interface while looking around for pflash.)
  • Since the code requires Python >=3.7, f-strings are available to us. Could you trade the + with use of f-strings a la f'if=xxxxx,file={omvf_image_path}'?
  • Could you make it two separate commits, one for the void filename, one replacing -bios?

What do you think?

CC void-linux/void-packages#11243

@hartwork
Copy link
Owner

hartwork commented May 9, 2023

@Animeshz PS: If you rebase into latest master with #173 just-merged, the CI will better explain where code formatting is off to the eyes of yapf.

@Animeshz
Copy link
Contributor Author

Animeshz commented May 10, 2023

  1. Yeah, never thought of, readonly makes it now launch without sudo, as it was needed earlier (in screenshot).
  2. Sure
  3. Sure

Copy link
Owner

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Animeshz wonderful, thank you! 👍 👍

@hartwork hartwork merged commit d575121 into hartwork:master May 10, 2023
@hartwork
Copy link
Owner

@Animeshz PS: I have released 2.8.0 with these changes both to GitHub and PyPI just now:

If someone wanted to package it for Void, thanks to you it should now work without patching. Here's where it's currently available to the eyes of repology.org:

grub2-theme-preview packaging status

I will bump to 2.8.0 in Gentoo myself in a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants