Add Void Linux support and change the way UEFI image is loaded in qemu. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
reviewed
May 9, 2023
There was a problem hiding this comment.
Hi @Animeshz that's a nice pull request! 👍
There are three details that I would like to bring up for discussion:
- Should we add the
readonlyflag? (I came across it at https://wiki.archlinux.org/title/Unified_Extensible_Firmware_Interface while looking around forpflash.) - Since the code requires Python >=3.7, f-strings are available to us. Could you trade the
+with use of f-strings a laf'if=xxxxx,file={omvf_image_path}'? - Could you make it two separate commits, one for the void filename, one replacing
-bios?
What do you think?
|
|
@Animeshz PS: I have released 2.8.0 with these changes both to GitHub and PyPI just now:
If someone wanted to package it for Void, thanks to you it should now work without patching. Here's where it's currently available to the eyes of repology.org: I will bump to 2.8.0 in Gentoo myself in a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/share/qemu/edk2-x86_64-code.fdas a search path for OVMF image.-bioswith-drive, with the old -bios option, it wasqemu: could not load PC BIOS '/usr/share/qemu/edk2-x86_64-code.fd'.I believe I found this format of specifying uefi image from this article, in the "Testing" part.
Example: