-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep orignal order if inputs are nil for caseInsensitiveCmp
#191
fix: keep orignal order if inputs are nil for caseInsensitiveCmp
#191
Conversation
Your newly added case failed, see travis log. I tried shopify/liquid but find it rather confusing:
It seems that those items without the specified property are moved to the tail, and they are re-ordered alphabetically. I'm not sure whether keys in Ruby Map are ordered or not, but certainly it's not behaving the same way as JavaScript. |
🎉 This issue has been resolved in version 9.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Finally I find out that in Ruby all items with a Though this PR can't be merged due to the test case not passing, thank you for pointing this out and initiating the test case, @all-contributors please add richardo2016 for code |
I've put up a pull request to add @richardo2016! 🎉 |
thx for your attention to this feature! |
in function
caseInsensitiveCmp
, to keep original order when other items with specified propertyundefined
, we should use logic like below:simplify it, we got