You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, currently when we use new Hash(tagToken.args, true) we can support jekyll style variables in our custom tags, however when using built-in tags, such options is not possible for example, {% render "tmp", cur=var1 %}, as some teams have strong react background, and liquidjs Hash already support jekyll style variables, please make hash to default to a value defined in the options instead of hardcoding one:
// tokenizer.tsreadHash(jekyllStyle?: boolean): HashToken|undefined{this.skipBlank()if(this.peek()===',')++this.pconstbegin=this.pconstname=this.readNonEmptyIdentifier()if(!name)returnletvaluethis.skipBlank()constsep=jekyllStyle ? '=' : ':'/* Make this read from options passed to the engine */// ex: // const sep = jekyllStyle ? '=' : seperatorFromEngineOptionsif(this.peek()===sep){++this.pvalue=this.readValue()}returnnewHashToken(this.input,begin,this.p,name,value,this.file)}
by making this new seperatorFromEngineOptions default to ':' I think backward compatibility will be preserved.
The text was updated successfully, but these errors were encountered:
Hi, currently when we use
new Hash(tagToken.args, true)
we can support jekyll style variables in our custom tags, however when using built-in tags, such options is not possible for example,{% render "tmp", cur=var1 %}
, as some teams have strong react background, and liquidjs Hash already support jekyll style variables, please make hash to default to a value defined in the options instead of hardcoding one:by making this new
seperatorFromEngineOptions
default to ':' I think backward compatibility will be preserved.The text was updated successfully, but these errors were encountered: