Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement allow_false argument in default filter #435

Closed
sebastienros opened this issue Jan 2, 2022 · 2 comments
Closed

Implement allow_false argument in default filter #435

sebastienros opened this issue Jan 2, 2022 · 2 comments
Labels
feature requested

Comments

@sebastienros
Copy link

https://shopify.github.io/liquid/filters/default/#allowing-false
@harttle
Copy link
Owner

harttle commented Jan 2, 2022

Truthy and Falsy in LiquidJS is mostly aligned with shopify liquid. So I guess this feature is also compatible and good to have.

harttle added a commit that referenced this issue Jan 2, 2022
@harttle
feat: support allow_false for default filter, see #435
c756191
github-actions bot pushed a commit that referenced this issue Jan 2, 2022
@semantic-release-bot
chore(release): 9.32.0 [skip ci]
c7d2e1f 
# [9.32.0](v9.31.0...v9.32.0) (2022-01-02)

### Features

* support allow_false for `default` filter, see [#435](#435) ([c756191](c756191))
@harttle
Copy link
Owner

harttle commented Jan 2, 2022

Try v9.32.0

@harttle harttle closed this as completed Jan 19, 2022
@harttle harttle mentioned this issue Mar 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastienros @harttle