Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elsif is not supported for unless #268

Closed
rnovacek opened this issue Nov 23, 2020 · 1 comment
Closed

elsif is not supported for unless #268

rnovacek opened this issue Nov 23, 2020 · 1 comment
Labels
bug released

Comments

@rnovacek
Copy link

rnovacek commented Nov 23, 2020 •
edited by harttle
Loading

This seems to be valid syntax (at least in Shopify's liquid):

{%- unless condition1 -%}
      <div>X</div>
{%- elsif condition2 -%}
      <div>Y</div>
{% else %}
      <div>Z</div>
{% endunless %}

Shopify docs says:

elsif / else
Adds more conditions within an if or unless block.

liquidjs throws an error saying: RenderError: tag "elsif" not found.
@harttle harttle added the bug label Nov 25, 2020
@harttle harttle closed this as completed in 2bbf501 Dec 7, 2020
harttle pushed a commit that referenced this issue Dec 7, 2020
@semantic-release-bot
chore(release): 9.17.0 [skip ci]
090c88e 
# [9.17.0](v9.16.1...v9.17.0) (2020-12-07)

### Bug Fixes

* elsif is not supported for unless, fixes [#268](#268) ([2bbf501](2bbf501))
* enforce string-type pattern in `replace`, fixes [#243](#243) ([c8afa39](c8afa39))
* raw block not ignoring {% characters, fixes [#263](#263) ([a492d8e](a492d8e))

### Features

* passing liquid to FilterImpl, closes [#277](#277) ([f9f595f](f9f595f))
@harttle
Copy link
Owner

harttle commented Dec 7, 2020

🎉 This issue has been resolved in version 9.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rnovacek @harttle