Issue #36: Minor Improvements to CSS, Added Icons, Accessibility Improvement #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AalokeCode
changed the title
AalokeCode
changed the title
harsxv
requested changes
Oct 23, 2024
|
Alright will work on it! |
|
Hey @harsxv. I've updated the code. Please let me know if there are any changes! Also could you please label the PR with hacktoberfest and link the issue |
harsxv
requested changes
Oct 24, 2024
index.html.theme
Outdated
| <div class="logo"><img src="assets/apple-touch-icon.png" alt="Logo"/><h1>TinyStatus</h1></div> | ||
| <div class="icons"> | ||
| <a href="https://github.com/harsxv/tinystatus" target="_blank"><svg xmlns="http://www.w3.org/2000/svg" width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-github"><path d="M15 22v-4a4.8 4.8 0 0 0-1-3.5c3 0 6-2 6-5.5.08-1.25-.27-2.48-1-3.5.28-1.15.28-2.35 0-3.5 0 0-1 0-3 1.5-2.64-.5-5.36-.5-8 0C6 2 5 2 5 2c-.3 1.15-.3 2.35 0 3.5A5.403 5.403 0 0 0 4 9c0 3.5 3 5.5 6 5.5-.39.49-.68 1.05-.85 1.65-.17.6-.22 1.23-.15 1.85v4"/><path d="M9 18c-4.51 2-5-2-7-2"/></svg> GitHub</a> | ||
| <a href="https://buymeacoffee.com/harsxv" target="_blank"><svg xmlns="http://www.w3.org/2000/svg" width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-coffee"><path d="M10 2v2"/><path d="M14 2v2"/><path d="M16 8a1 1 0 0 1 1 1v8a4 4 0 0 1-4 4H7a4 4 0 0 1-4-4V9a1 1 0 0 1 1-1h14a4 4 0 1 1 0 8h-1"/><path d="M6 2v2"/></svg> Buy Me a Coffee</a> |
There was a problem hiding this comment.
Hi @AalokeCode! Could you please remove the line about the Buy Me a Coffee button? I think it's a great idea, but I'd prefer to keep the status page tidy for everyone. I don't want to get all the coffee to myself in status page 😆
Once that's done, we'll be all set to merge. Thanks!
There was a problem hiding this comment.
I've also updated the label and linked the issue for you :)
There was a problem hiding this comment.
Alright! I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Icons, Added few buttons, Edited colours for dark mode. Icons from PhosphorIcons. For Accessibility & SEO, I've checked with Lighthouse since I'm running it locally.