Fix: DNS status check might failed in Windows #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Abstract The `ping` command's parameter is different between Windows and other Unix-like system. Which may cause `check_ping` always failed when user run `tinystatus.py` in Windows because '-c' parameter not means 'count' as it in Linux or MacOS. Also,the time unit is 'millisecond' for '-w' parameter,which means 'time to wait for response' in Windows's `ping` command,so the value change from `2 `to `2000` . # More Details [Microsoft Documents](https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/ping).
harsxv
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
The
pingcommand's parameter is different between Windows and other Unix-like system.Which may cause
check_pingalways failed when user runtinystatus.pyin Windows because '-c' parameter not means 'count' as it in Linux or MacOS.Also,the time unit is 'millisecond' for '-w' parameter,which means 'time to wait for response' in Windows's
pingcommand,so the value change from2to2000.More Details
Microsoft Related Documents.