Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cards clickable #24

Merged
merged 8 commits into from
Sep 18, 2024
Merged

make cards clickable #24

merged 8 commits into from
Sep 18, 2024

Conversation

glowinthedark
Copy link
Contributor

@glowinthedark glowinthedark commented Sep 14, 2024

It's a frequent use case to need to navigate to a service rather than just displaying its status. This will also allow using the status page as some kind of 'dashboard' that allows navigating to services.

For entries of type: ping the url could, for example, point to some kind of configuration page or whatever the user finds appropriate.

The PR adds the url key to checks.yaml which can point, for example, to the service main page or some custom troubleshooting URL. If the key is missing then the value of the host key is used as a fallback.

Example:

    - name: Wikipedia Home
      type: http
      host: https://www.wikipedia.org
      url: https://en.wikipedia.org/wiki/Main_Page
      expected_code: 200

linkify card name using `url` key in `checks.yaml` if present or otherwise fallback to `host`
add sample `url` keys to certain entries in checks.yaml
Copy link
Owner

@harsxv harsxv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clickable cards! Thumbs up.
However, I’m not a fan of the blue color for visited text. Could we please change it back to black?

Also, it might be useful to make this optional, so if no url is defined, the card remains static and non clickable.

update css colors, ui
- pass None to template when `url` not defined in yaml; do not fallback to `host`
@glowinthedark
Copy link
Contributor Author

@harsxv: removed fallback to host when there is no url in the config; also restored black shades

Copy link
Owner

@harsxv harsxv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you

@harsxv harsxv merged commit af9c8d1 into harsxv:master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants