Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it clean code and disable right click #21

Merged
merged 5 commits into from
Sep 9, 2024
Merged

make it clean code and disable right click #21

merged 5 commits into from
Sep 9, 2024

Conversation

masdzub
Copy link
Contributor

@masdzub masdzub commented Sep 9, 2024

Hi Harry, I want to contribute again.
Updating some scripts and making the clean code 🙏🏼

harsxv
harsxv requested changes Sep 9, 2024
View reviewed changes
Copy link
Owner

@harsxv harsxv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile: would be more clean if you can remove the ./ after each files
Can you please addressed this first before I will merged?

harsxv
harsxv requested changes Sep 9, 2024
View reviewed changes
Copy link
Owner

@harsxv harsxv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it’s necessary to disable right-click

@masdzub
Copy link
Contributor Author

masdzub commented Sep 9, 2024

Hi Harry, it's done. please try check it again.

@harsxv harsxv merged commit a58cd00 into harsxv:master Sep 9, 2024
@harsxv
Copy link
Owner

harsxv commented Sep 9, 2024

Neat, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsxv harsxv harsxv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masdzub @harsxv