Make dependency on "failure" optional #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While being compatible with
failure
is nice, the way it is currently done in this library forces the dependency on all users of this crate, even if they do not use it at all.The biggest example of this issue is
bindgen
, the biggest dependent of this crate but which does not usefailure
, hence making everybody that usesbindgen
depend onfailure
(and all its dependencies) for pretty much nothing.This PR makes the dependency on
failure
optional, by creating a newuse_failure
feature that controls whether or not the dependency onfailure
is enabled.This feature is enabled by default to avoid any breaking changes, but it can be disabled by any dependent crate that does not wish to use
failure
and can get rid of the extra dependency.The CI configurations were also updated, so they run tests in both configurations: with and without default features enabled.